-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux/Mac needs sudo #924
Linux/Mac needs sudo #924
Conversation
Sudo is needed to install some requirements
Brew needs sudo aswel, and added installation or mac url to installation guide
@maestroi not needed if you run it inside virtualenv, instead of messing with your system-wide package I'd prefer using virtualenv. |
@widnyana than maybe its good to add that to the linux instruction aswel ? |
|
||
``` | ||
$ git clone -b master https://github.com/PokemonGoF/PokemonGo-Bot | ||
$ cd PokemonGo-Bot | ||
$ virtualenv . | ||
$ source bin/activate | ||
$ pip install -r requirements.txt | ||
$ sudp pip install -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mistyped here, it's sudo not sudp
Typo!
Agreed that using virtualenv is a safe choice, it lowers the risk of screw up your OS. Example:
|
Linux/mac do NOT need sudo for running it- and it's a very bad idea to tell people they need it. |
👎 virtualenv is good enough. |
after some comments changes to use virtualenv
Changed the instructions to use virtualenv 👍 |
@maestroi please explain in the readme why virtualenv is recommended and that we do not officially support running the bot without it (so user needs to figure out whatever happens if they don't use it). |
There is no need to use virtualenv or sudo on Linux. You should pass --user if you want to install dependencies for your user, like this: That also makes virtualenv useless. |
@AnAkkk virtualenv is not only about installing packages for the local user. It's about having many clean Python environments and being able to switch between them, so you don't get version conflicts. Virtualenv is so useful that in Python 3.5 they embedded the idea into a Please, do some research about a tool before saying it has become useless just because another tool implement something that is very far from the objective of the "useless" tool. |
Wouldn't "Recommended" sound better than "Recommend"? |
@douglascamata its done i guess |
you have my +1 |
@douglascamata can you change the label ? |
Short Description:
added sudo to installation guide
Fixes:
Sudo is needed to install some requirements