Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux/Mac needs sudo #924

Merged
merged 6 commits into from
Jul 26, 2016
Merged

Linux/Mac needs sudo #924

merged 6 commits into from
Jul 26, 2016

Conversation

maestroi
Copy link
Contributor

@maestroi maestroi commented Jul 26, 2016

Short Description:
added sudo to installation guide
Fixes:

  • sudo added for linux installation
  • sudo added for Mac OSX installation

Sudo is needed to install some requirements

Sudo is needed to install some requirements
@maestroi maestroi changed the title Linux/Mac needs sudp Linux/Mac needs sudo Jul 26, 2016
Brew needs sudo aswel, and added installation or mac url to installation guide
@widnyana
Copy link

@maestroi not needed if you run it inside virtualenv,

instead of messing with your system-wide package I'd prefer using virtualenv.

@maestroi
Copy link
Contributor Author

@widnyana than maybe its good to add that to the linux instruction aswel ?


```
$ git clone -b master https://github.com/PokemonGoF/PokemonGo-Bot
$ cd PokemonGo-Bot
$ virtualenv .
$ source bin/activate
$ pip install -r requirements.txt
$ sudp pip install -r requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mistyped here, it's sudo not sudp

@felipemeamaral
Copy link
Contributor

Agreed that using virtualenv is a safe choice, it lowers the risk of screw up your OS.
If someone would want to use multiple instances of bot by a script just make use of . notation from virtualenv.

Example:

. ./bin/activate

@CapCap
Copy link
Contributor

CapCap commented Jul 26, 2016

Linux/mac do NOT need sudo for running it- and it's a very bad idea to tell people they need it.

@evrardjp
Copy link

👎 virtualenv is good enough.
The only change we could do is replace "(Optional)" by something like "(Recommended - optional)" in the docs

after some comments changes to use virtualenv
@maestroi
Copy link
Contributor Author

Changed the instructions to use virtualenv 👍

@douglascamata
Copy link
Member

douglascamata commented Jul 26, 2016

@maestroi please explain in the readme why virtualenv is recommended and that we do not officially support running the bot without it (so user needs to figure out whatever happens if they don't use it).

@AnAkkk
Copy link

AnAkkk commented Jul 26, 2016

There is no need to use virtualenv or sudo on Linux. You should pass --user if you want to install dependencies for your user, like this:
pip install -r requirements.txt --user

That also makes virtualenv useless.

@douglascamata
Copy link
Member

douglascamata commented Jul 26, 2016

@AnAkkk virtualenv is not only about installing packages for the local user. It's about having many clean Python environments and being able to switch between them, so you don't get version conflicts. Virtualenv is so useful that in Python 3.5 they embedded the idea into a venv module of the standard library (https://docs.python.org/3/library/venv.html).

Please, do some research about a tool before saying it has become useless just because another tool implement something that is very far from the objective of the "useless" tool.

@DavidK1m
Copy link
Contributor

Wouldn't "Recommended" sound better than "Recommend"?

maestroi added 2 commits July 26, 2016 18:14
added a note for virtualenv
@maestroi
Copy link
Contributor Author

@douglascamata its done i guess

@douglascamata
Copy link
Member

you have my +1

@maestroi
Copy link
Contributor Author

@douglascamata can you change the label ?

@MaxLeiter
Copy link

MaxLeiter commented Jul 26, 2016

👍 Thanks!

Approved with PullApprove

@MaxLeiter MaxLeiter merged commit 8934837 into PokemonGoF:master Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants