Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep best CP pokemon after merging all changes. #953

Closed
wants to merge 2 commits into from
Closed

Keep best CP pokemon after merging all changes. #953

wants to merge 2 commits into from

Conversation

koper89
Copy link

@koper89 koper89 commented Jul 26, 2016

Former pull:
#880

@koper89 koper89 mentioned this pull request Jul 26, 2016
@fredrik-hellmangroup
Copy link
Contributor

can you push in updated config.json.example(s) please

@koper89
Copy link
Author

koper89 commented Jul 27, 2016

Added

@Nihisil
Copy link
Contributor

Nihisil commented Jul 27, 2016

Please, merge current dev into your PR and resolve all conflicts. I would like to have this PR merged into dev after this 👍

@anziclone
Copy link

We need to filter by Pokemon ID than by name...This will ensure all Pokemon get checked. Besides this, the functionality doesn't seem to be working.

@fredrik-hellmangroup
Copy link
Contributor

@koper89 your code doesnt read specific configured pokemons, but you have included it into config example.
I like this feature, could you please correct your code, also as @Nihisil said. merge down current dev in order to resolve conflicts :)

@solderzzc
Copy link
Contributor

Oh, no, conflict again...

@koper89
Copy link
Author

koper89 commented Jul 27, 2016

@surfaace Correct me If I'm wrong but this line:
release_config = self._get_release_config_for(pokemon_name)
Is reading config based of pokemon if exists if not then goes to any. So it does take specific pokemons as well.

@Nihisil
Copy link
Contributor

Nihisil commented Jul 28, 2016

I think PR can be closed, because we pulled a little bit general version of it to the dev #1302

@elicwhite elicwhite closed this Jul 28, 2016
@ironbishop ironbishop mentioned this pull request Jul 28, 2016
hoanghuynh pushed a commit to hoanghuynh/PokemonGo-Bot that referenced this pull request Sep 28, 2016
* Added styles
* remove useless comments

* css link restore

* css fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants