Fix config.json.pokemons.example release config #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iv' to 'release_below_iv' in config.json.pokemons.example to match what code searchs for
|
Modified also evolve_all_worker to use There are no more places where |
|
Same with cp_iv_logic to logic, as seen in #947 |
|
Looks good to me. |
|
Thanks. |
MFizz
pushed a commit
to MFizz/PokemonGo-Bot
that referenced
this pull request
Jul 29, 2016
* Replace 'release_under_cp' to 'release_below_cp', and 'release_under_iv' to 'release_below_iv' in config.json.pokemons.example to match what code searchs for * Make evolve_all_worker use release_below_cp and release_below_iv too * Replace cp_iv_logic to logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties in the json were
release_under_cpandrelease_under_iv, but code is searching forrelease_below_cpandrelease_below_iv, so this was not working if used by users.