Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Studio to migrate the new project #383

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

Palbolsky
Copy link
Collaborator

@Palbolsky Palbolsky commented Sep 3, 2024

Description

Studio is currently unable to migrate a new project because the project.studio file does not exist in the new project archive. Furthermore, since the file does not exist, Studio creates the file and therefore uses the current version of the application.
No migration can therefore be carried out.

This PR allows Studio to update the project.studio file and retain the latest version of Studio used in the Technical Demo / new project archive. However, this feature is only functional if there is a project.studio in the archive, which is not the case with 1.0.7.

Note before testing

You need a specific version of the new project archive which contains the project.studio file:
https://mega.nz/file/h5pDQSzQ#EDGI4QkIrxTWbSZ0ntpoK7snUMn9f9uf6wyByIJFz_U

Copy the archive to the root of the Pokémon Studio project.
https://github.com/user-attachments/assets/2c16338d-e938-4150-ab1f-90ca3a010208

In the file \src\backendTasks\checkDownloadNewProject.ts, in the line 28, change needDownload: true by needDownload: false.

Tests to perform

  • Create a new project and check that it opens correctly
  • Check that creature form feature works correctly

@Palbolsky Palbolsky added the technical story Issues related to technical work label Sep 3, 2024
@Palbolsky Palbolsky self-assigned this Sep 3, 2024
Copy link
Collaborator

@AerunDev AerunDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je viens de tester cette branche en suivant les étapes de test.
Pour info, l'archive fournie n'a pas le bon nom, et contient un dossier au lieu des fichiers directement, du coup il m'a fallu comprendre ça pour avancer.

Lorsque je créé un projet, le projet se créé bien mais au moment du chargement j'ai 830 fichiers non conformes.
Parmi les erreurs Zod :

} Error: [
  {
    "code": "invalid_type",
    "expected": "object",
    "received": "undefined",
    "path": [
      "forms",
      0,
      "formTextId"
    ],
    "message": "Required"
  }
]

} Error: [
  {
    "code": "invalid_type",
    "expected": "object",
    "received": "string",
    "path": [
      "bgm"
    ],
    "message": "Expected object, received string"
  },
  {
    "code": "invalid_type",
    "expected": "object",
    "received": "string",
    "path": [
      "bgs"
    ],
    "message": "Expected object, received string"
  }
]

} Error: [
  {
    "code": "invalid_type",
    "expected": "object",
    "received": "string",
    "path": [
      "bgm"
    ],
    "message": "Expected object, received string"
  },
  {
    "code": "invalid_type",
    "expected": "object",
    "received": "string",
    "path": [
      "bgs"
    ],
    "message": "Expected object, received string"
  }
]

@Palbolsky
Copy link
Collaborator Author

J'avais pas mis le bon lien de téléchargement. Tu peux réessayer ça devrait être bon.

@AerunDev
Copy link
Collaborator

AerunDev commented Sep 6, 2024

C'est tout bon pour moi avec la bonne archive ! 😄

@Palbolsky Palbolsky merged commit a86364f into develop Sep 7, 2024
2 checks passed
@Palbolsky Palbolsky deleted the allow-studio-to-migrate-new-project branch September 7, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical story Issues related to technical work
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants