13x Performance for Export chatlog, update rust_g to 0.4.6-vorestation #7744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VOREStation/VOREStation#9246
![https://i.tigercat2000.net/2020/10/dreamdaemon_wsdGma3Q7r.png](https://camo.githubusercontent.com/38406a1708ed2cb8c09c5d077aa7d13618207001957dd37688df1df548d01513/68747470733a2f2f692e7469676572636174323030302e6e65742f323032302f31302f647265616d6461656d6f6e5f777364476d61335137722e706e67)
Profiler indicates that over 5 calls, there was roughly a 13x improvement by simply switching from << file writes to rustg_write_file.
Note: rust_g is no longer optional for this codebase. It's increasingly important for maintaining performance, and by using the generated .dm file from rust_g's build process (which does not allow for optional rust_g) we can keep up to date much more easily.
rust_g 0.4.6-vorestation is just rust_g 0.4.6 with this diff: (I'll bug Lesh to update our VOREStation/rust-g repo after tgstation/rust-g#39 is in)
Note, in order to run rust_g on a linux system, you must have all of these libraries: (Nothing special needed for windows)