add collapsible drawer to show/hide prompt #2269
Conversation
|
Thanks @naufandarmawan! I should have a review for you either today or tomorrow. |
There was a problem hiding this comment.
Hi @naufandarmawan! Thanks for your work on this issue. I left a couple of comments, but I think the high-level takeaway is that a simpler fix, whereby our existing collapsible code feature is expanded/refactored, would probably be preferable. Thank you again.
| {showPrompt ? ( | ||
| <CodeBlock lines={lines} language={"markdown"} data={prompt} /> | ||
| ) : null} | ||
| <motion.div |
There was a problem hiding this comment.
issue, blocking: Please match this to our existing style.
As implemented here, this component doesn't quite match our visual style. Using the "Input" and "Ouptut" components at https://policyengine.org/us/api, could you refactor this to better match our visual style?
This issue could probably even be solved by just refactoring the existing code component to allow for full collapsibility on default, without the need for react-collapse and motion.
Description
Use a collapsible drawer to show/hide the GPT prompt #377
Changes
Add collapsible drawer to show/hide prompt (in Analysis.jsx) using react-collapse
Screenshots
Before
After
Tests
Tested locally, the result similar to the screenshots