Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACS, rent and property taxes and 3-year CPS #35

Merged
merged 46 commits into from
Sep 23, 2024
Merged

Add ACS, rent and property taxes and 3-year CPS #35

merged 46 commits into from
Sep 23, 2024

Conversation

PavelMakarchuk
Copy link
Collaborator

Fixes #31

@MaxGhenis
Copy link
Contributor

Have you tried running it?

nikhilwoodruff
nikhilwoodruff reviewed Sep 13, 2024
View reviewed changes
acs.py Outdated Show resolved Hide resolved
policyengine_us_data/datasets/acs/acs.py Show resolved Hide resolved
MaxGhenis
MaxGhenis requested changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add acs/README.md linking to the codebook?

Also if easy, could you add rent and property tax as variables?

@PavelMakarchuk
Copy link
Collaborator Author

Could you add acs/README.md linking to the codebook?

Also if easy, could you add rent and property tax as variables?

Added a readme with documentation

We already include
GRNTP -> Gross Rent
RNTP -> Monthly rent

I don't see variables for property taxes in the dictionary

@MaxGhenis
Copy link
Contributor

image

@PavelMakarchuk
Copy link
Collaborator Author

PavelMakarchuk commented Sep 17, 2024 •
edited by nikhilwoodruff
Loading

[broken image removed by @nikhilwoodruff- weird gh issue?]
No idea how i missed that - added

@nikhilwoodruff
Copy link
Contributor

@MaxGhenis a few things (thanks @PavelMakarchuk; taking over the baton for this PR) you might want to take a look at (but not essential or blocking).

  • I've moved from our implementation of QRFs in survey-enhance to a more lightweight wrapper over quantile-forest which seems faster and better-written than mine. We still have the mean quantile ability. The new implementation wrapper is in utils/qrf.py.
  • Seems like we shouldn't calibrate real estate taxes from the SOI? But I can add calibration targets for total rent and property taxes, any ideas on the definitive source to use? They match the ACS totals after imputation.

@nikhilwoodruff nikhilwoodruff mentioned this pull request Sep 22, 2024
Closed
@MaxGhenis
Copy link
Contributor

Correct we should not calibrate real estate taxes from SOI. See #29 for other options.

@nikhilwoodruff
Copy link
Contributor

SNAP is looking really nice with the rent imputation: after applying USDA's 82% take-up rate, we get 103bn vs 107bn in 2023.

@nikhilwoodruff nikhilwoodruff changed the title Migrate ACS from policyengine-us Add ACS, rent and property taxes and 3-year CPS Sep 23, 2024
@nikhilwoodruff
Copy link
Contributor

Also tied in #67 here.

@nikhilwoodruff
Copy link
Contributor

Getting memory breaches but I'm going to merge since it ran locally.

@nikhilwoodruff nikhilwoodruff merged commit 4e1d1e0 into main Sep 23, 2024
2 of 3 checks passed
@nikhilwoodruff nikhilwoodruff deleted the acs_migrate branch September 25, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilwoodruff nikhilwoodruff nikhilwoodruff left review comments

@MaxGhenis MaxGhenis MaxGhenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate ACS from policyengine-us
3 participants
@PavelMakarchuk @MaxGhenis @nikhilwoodruff