Change _lsr to _behavioral_response
#5286
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5286 +/- ##
==========================================
- Coverage 99.12% 99.00% -0.13%
==========================================
Files 2592 2613 +21
Lines 37707 38055 +348
Branches 162 165 +3
==========================================
+ Hits 37378 37675 +297
- Misses 297 347 +50
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
PavelMakarchuk
requested changes
Oct 31, 2024
| lsr = person("labor_supply_behavioral_response", period) | ||
| if (lsr != 0).any(): | ||
| income_effect = person("income_elasticity_lsr", period) | ||
| income_effect = person( |
There was a problem hiding this comment.
could you add some unit tests for anything that is not covered here?
|
We will need to make some adjustments once #5287 merged |
is it already been merged? |
PavelMakarchuk
requested changes
Nov 4, 2024
| @@ -5,18 +5,6 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [1.137.3] - 2024-11-01 16:53:33 | |||
| @@ -10132,8 +10120,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
|
|
|||
|
|
|||
| [1.137.3]: https://github.com/PolicyEngine/policyengine-us/compare/1.137.2...1.137.3 | |||
| @@ -8580,13 +8580,3 @@ | |||
| fixed: | |||
| - remove uprating for SNAP variables that don't change | |||
| date: 2024-10-31 18:57:07 | |||
| - bump: patch | |||
| @@ -1,13 +1,13 @@ | |||
| description: Colorado provides a flat sales tax refund credit of this amount. | |||
| values: | |||
| 2023-01-01: 800 | |||
| 2023-01-01: 661 | |||
| @@ -51,20 +51,3 @@ | |||
| filing_status: SEPARATE | |||
| output: | |||
| co_sales_tax_refund: 234 | |||
|
|
|||
| @@ -1,7 +1,4 @@ | |||
| from policyengine_us.model_api import * | |||
| from policyengine_us.variables.gov.states.il.tax.income.exemptions.il_personal_exemption_eligibility_status import ( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5258