Add sidebar in manifesto page to share content #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nancruz Can we add some margin-left to each paragraph and when the use mouse hover the paragraph sharing section appears on the left. Then, the user just needs to click on twitter (or other) image. What do you think guys? Also, how this works in mobile? |
|
@luisiul359 the hover thing might not work on mobile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we add the sidebar next to each manifesto item to share that item on twitter.
Currently, the twitter text contains the link to the manifesto section.
In my opinion, I think that isn't clear for users that they click on the sidebar to share some content on twitter.
What is your opinion?