Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iv ocex tests #819

Merged
merged 7 commits into from
Jun 24, 2023
Merged

Iv ocex tests #819

merged 7 commits into from
Jun 24, 2023

Conversation

35359595
Copy link
Contributor

@35359595 35359595 commented Jun 21, 2023

Describe your changes

Missing tests for OCEX pallet added extrinsics:

  • remove_proxy
  • set_snapshot
  • change_pending_withdrawal_limit
  • change_snapshot_interval_block
  • set_exchange_state
  • whitelist_orderbook_operator

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@35359595 35359595 self-assigned this Jun 21, 2023
@35359595 35359595 added the A0-PleaseReview Pull request needs code review. label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.77 🎉

Comparison is base (9ede724) 33.82% compared to head (258b13a) 34.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #819      +/-   ##
===========================================
+ Coverage    33.82%   34.60%   +0.77%     
===========================================
  Files           64       64              
  Lines         4381     4381              
===========================================
+ Hits          1482     1516      +34     
+ Misses        2899     2865      -34     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gauthamastro Gauthamastro merged commit 29ec834 into Develop Jun 24, 2023
@Gauthamastro Gauthamastro deleted the iv-ocex-tests branch June 24, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants