Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iv fixes #838

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Iv fixes #838

merged 3 commits into from
Jul 20, 2023

Conversation

35359595
Copy link
Contributor

  • clone of each deposit for store and dispose instead of full deposits vec cloning;
  • combined logic for deposit processing and fees collected only if there are deposits;
  • logs levels demoted to debug from info in ocex pallet;

@35359595 35359595 self-assigned this Jul 19, 2023
@35359595 35359595 added the A0-PleaseReview Pull request needs code review. label Jul 19, 2023
@35359595 35359595 mentioned this pull request Jul 19, 2023
Merged
@Gauthamastro Gauthamastro merged commit 08f6360 into gj/on-chain-validation Jul 20, 2023
@Gauthamastro Gauthamastro deleted the iv-fixes branch July 20, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauthamastro Gauthamastro Gauthamastro approved these changes

Assignees

@35359595 35359595

Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@35359595 @Gauthamastro