Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more features to match MITK and NIST F2D-J #184

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

friskluft
Copy link
Member

No description provided.

Copy link

sweep-ai bot commented Dec 11, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@sameeul
Copy link
Member

sameeul commented Dec 12, 2023

Please see the latest failures in #186 .

             for column in pd_columns:
    
                column_list = features[column].tolist()
                arrow_list = arrow_pd[column].tolist()
    
                assert len(column_list) == len(arrow_list)
    
                for j in range(len(column_list)):
                    feature_value = column_list[j]
                    arrow_value = arrow_list[j]
    
                    #skip nan values
                    if (isinstance(feature_value, (int, float)) and math.isnan(feature_value)):
                        if (not math.isnan(arrow_value)):
                            assert False
    
                        continue
>                   assert feature_value == pytest.approx(arrow_value, rel=1e-6, abs=1e-6)
E                   assert 2.1722222222222225 == -4.29168169280656e-310 � 1.0e-06
E                     comparison failed
E                     Obtained: 2.1722222222222225
E                     Expected: -4.29168169280656e-310 � 1.0e-06

The Arrow test cases are mainly failing. My guess is that output_to_buffer.cpp also needs to be updated to keep pandas dataframe and Arrow output in sync.
image

Something similar to this.

@sameeul sameeul self-requested a review December 12, 2023 15:35
@sameeul sameeul merged commit 4683dc8 into PolusAI:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants