Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use approx equal to compare feature values #185

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Use approx equal to compare feature values #185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73dc716
Use approx equal to compare feature values
JesseMckinzie Dec 11, 2023
3c70aa2
Specify relative tolerance
JesseMckinzie Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/python/test_nyxus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ def test_parquet_writer(self):
assert False

continue
assert feature_value == arrow_value
assert feature_value == pytest.approx(arrow_value, rel=1e-6)

open_parquet_file.close()

Expand Down Expand Up @@ -389,7 +389,7 @@ def test_parquet_writer_file_naming(self):
assert False

continue
assert feature_value == arrow_value
assert feature_value == pytest.approx(arrow_value, rel=1e-6)


file.close()
Expand Down Expand Up @@ -442,7 +442,7 @@ def test_make_arrow_ipc(self):
assert False

continue
assert feature_value == arrow_value
assert feature_value == pytest.approx(arrow_value, rel=1e-6)

path = nyx.get_arrow_ipc_file()

Expand Down Expand Up @@ -475,7 +475,7 @@ def test_arrow_ipc(self):
assert False

continue
assert feature_value == arrow_value
assert feature_value == pytest.approx(arrow_value, rel=1e-6)

@pytest.mark.arrow
def test_arrow_ipc_file_naming(self):
Expand Down Expand Up @@ -508,7 +508,7 @@ def test_arrow_ipc_file_naming(self):
assert False

continue
assert feature_value == arrow_value
assert feature_value == pytest.approx(arrow_value, rel=1e-6)

@pytest.mark.arrow
def test_arrow_ipc_no_path(self):
Expand Down Expand Up @@ -541,7 +541,7 @@ def test_arrow_ipc_no_path(self):
assert False

continue
assert feature_value == arrow_value
assert feature_value == pytest.approx(arrow_value, rel=1e-6)

@pytest.mark.arrow
def test_arrow_ipc_path(self):
Expand Down