[WIP] Build system changes to allow pip installation from source #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yChordLite into compile_stuff_for_pip
…yChordLite into compile_stuff_for_pip
…yChordLite into compile_stuff_for_pip
williamjameshandley
requested changes
Apr 14, 2019
| ifeq ($(MPI), 1) | ||
| FC = mpif90 |
There was a problem hiding this comment.
I think that this removal of the FC variable is causing the continuous integration travis build to fail. Perhaps you could take a look to see if .travis.yml also needs to be updated (I think this would involve adjusting the build.sh script so it uses your new command, rather than make)? It also no longer works if we try to build it the old way, i.e. using make.
| LDLIBS += -lstdc++ | ||
| # clang uses a different libstdc++ than GCC | ||
| ifneq (,$(findstring clang,$(shell '$(CXX)' -v 2>&1))) | ||
| LDLIBS += -lc++ |
There was a problem hiding this comment.
This is a very nice spot if this allows it to work for macs -- I think many people have run into problems with clang in the past, but nobody has suggested this as a solution
|
Should be replaced by PR #24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to unify the build process such that a single
python setup.py installbuilds and installs the whole library. Ditto forpip.To accomplish this,
libchord.sois now being compiled at thebuild_pystep (for stupid, setuptools-related reasons) and then copied into the package.The extension is compiled with the right
rpath,$ORIGIN, andinstall_namesettings so that things work. Getting this to work cost me a good chunk of my sanity and will probably leave me with setuptools related PTSD for the foreseeable future.To summarise:
python setup.py install,pip install .,pip install git+https://github.com/tilmantroester/PolyChordLite.git@compile_stuff_for_pip#egg=pypolychordseem to work on both Linux and macOS for MPI.--no-mpiflag. Note that the flag position is aftersetup.py, e.g.,python setup.py --no-mpi install, for stupid, setuptools-related reasons.python setup.py cleancommand that runsmake verycleanThis should probably be tested in more detail. At the moment it is based of the
setup_pipbranch but I think it could easily be rebased to master.