Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyproject #27

Closed
wants to merge 10 commits into from
Closed

Pyproject #27

wants to merge 10 commits into from

Conversation

steven-murray
Copy link

@steven-murray steven-murray commented Jul 25, 2019

Adds pyproject.toml which should de-necessitate pre-installing numpy into a fresh environment before installing pypolychord.

Closes #26

@steven-murray
Copy link
Author

I think the problem here is that python setup.py install doesn't use the pyproject.yaml. I updated to use pip install . instead -- let's see if that works.

@steven-murray
Copy link
Author

I think there's something going on here that I don't understand. Could you look at the travis errors? It's picking up the numpy requirement fine, and installing pypolychord fine, but when trying to import it, it's saying that it can't find the shared lib.

@williamjameshandley
Copy link
Member

Ah, pip installing polychord is currently an open PR #24 Do you have to use pip to get the .toml file to work?

@steven-murray
Copy link
Author

Hmmm yes I think so. I'll have a bit more of a look.

@steven-murray
Copy link
Author

Yes, using python setup.py install of course literally just loads setup.py with python, and so will break if numpy is not installed. pip instead first checks pyproject.toml for build deps. Perhaps this PR should just sit until #24 is merged. Is that happening soon?

@williamjameshandley
Copy link
Member

@tilmantroester, what remains to be done to fix #24 ?

@tilmantroester
Copy link
Contributor

Fixing the macOS travis builds and re-adding python 2 support. The travis failure is bizarre while the python 2 part should be straightforward to implement but I haven't had time to look into it.

@williamjameshandley
Copy link
Member

Hi @steven-murray. There have been some fairly major changes here to the python setup after the merge of #24, and a few new errors are emerging now on the travis build. Have you seen these before in your experience of implementing toml files?

@steven-murray
Copy link
Author

Wow, no I've never seen errors like that. Looks like it's mostly working with MPI=1, but not with MPI=0. You might have to install some blas library manually?

williamjameshandley added a commit that referenced this pull request Jun 18, 2020
* Add .circleci/config.yml

* Made the directory for chains

* Still need numpy until #27 successfully is merged

* Installing mpi

* Trying with just libopenpi-dev

* Verbose output to see what is going on

* Trying with explicitly setting the fortran compiler for debian
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build requires numpy
3 participants