Minor Fixes & Adjustments. #201

simbuerg · 2018-07-11T21:44:04Z

This fixes a few bugs that came up:

Turn ConfigPath's eager validation into lazy validation. Otherwise, we create directories for
default values.
Support for SQLite introduced a few bugs with schema versioning:
- Correct version was not forced when we install versioning on an existing schema.
- Endless loop when user declines schema versioning.
GUIDs have triggered an exception in the SQLite driver of sqlalchemy.

We provide the build_dir inside a ConfigPath object. If the user wants to rely on a directory without ConfigPath protection, it is his problem. Reminder: !create-if-needed in front of your path string makes sure that it becomes ConfigPath protected.

This avoids a problem where ConfigPath would create the default values as soon as they are loaded but before they are updated with a new value.

codecov · 2018-07-11T21:49:17Z

Codecov Report

Merging #201 into master will increase coverage by 0.07%.
The diff coverage is 70.96%.

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   50.65%   50.73%   +0.07%     
==========================================
  Files         101      101              
  Lines        5861     5872      +11     
==========================================
+ Hits         2969     2979      +10     
- Misses       2892     2893       +1

Impacted Files	Coverage Δ
benchbuild/cli/run.py	`37.66% <ø> (+0.95%)`	⬆️
benchbuild/cli/bootstrap.py	`42.85% <ø> (-0.39%)`	⬇️
benchbuild/utils/path.py	`36.73% <ø> (ø)`	⬆️
benchbuild/utils/log.py	`18.18% <0%> (ø)`	⬆️
benchbuild/utils/user_interface.py	`50% <100%> (+4.83%)`	⬆️
benchbuild/utils/schema.py	`77.88% <63.15%> (-0.49%)`	⬇️
benchbuild/utils/settings.py	`70.21% <85.71%> (-0.04%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709db10...983a961. Read the comment docs.

Minor Fixes & Adjustments. Former-commit-id: f76d5ee81286277ae68fb2472d92dabed0377747 Former-commit-id: 4918c2f28422965aed83b411b06b3347b9178902 [formerly 87c3bc69cacd882fe5884c3c473e4ff0d784049c] [formerly 6d5feb23cfde5d196a59b90279bf8db7d139c147 [formerly c23a1097fe8630e9d1e39a02b5b2840ca36be486]] Former-commit-id: 0cc053f672929af0f19f5e24abf58f77db8db544 [formerly 9c9a8ba60656b8fda2231766c01a0d5a874e7a1d] Former-commit-id: a282d26bdb130b4c57e88672e7b84fef014d8fb0

simbuerg added 10 commits July 11, 2018 14:22

utils/schema: catch operationalerror thrown by sqlite backend

ca0b2aa

utils/schema: force correct version when a new schema is created

4b4c6ea

utils/schema: do not log an error when we use sqlite with GUIDs

8915b46

utils/ui: track an automated response when not running with a TTY

87bc9e7

utils/log: revert logging format change

fe22c63

utils/path: wording of mkdir_interactive was wrong.

23577da

utils/settings: do not validate ConfigPath on creation, but on access.

839407a

This avoids a problem where ConfigPath would create the default values as soon as they are loaded but before they are updated with a new value.

utils/ui: provide format arguments as function arguments

d2fa824

utils/schema: hotfix endless loop when user declines schema versioning.

983a961

simbuerg merged commit 837297a into master Jul 11, 2018

simbuerg deleted the b/fix-ConfigPath branch July 11, 2018 21:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor Fixes & Adjustments. #201

Minor Fixes & Adjustments. #201

simbuerg commented Jul 11, 2018

codecov bot commented Jul 11, 2018 •

edited

Loading

Minor Fixes & Adjustments. #201

Minor Fixes & Adjustments. #201

Conversation

simbuerg commented Jul 11, 2018

codecov bot commented Jul 11, 2018 • edited Loading

Codecov Report

codecov bot commented Jul 11, 2018 •

edited

Loading