Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): use mutable generic container #508

Merged
merged 10 commits into from
Oct 11, 2022

Conversation

simbuerg
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 50.74% // Head: 52.21% // Increases project coverage by +1.46% 🎉

Coverage data is based on head (3e1e2b3) compared to base (cd65176).
Patch coverage: 86.95% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage   50.74%   52.21%   +1.46%     
==========================================
  Files         124      124              
  Lines        8207     8161      -46     
  Branches     1274     1263      -11     
==========================================
+ Hits         4165     4261      +96     
+ Misses       3882     3725     -157     
- Partials      160      175      +15     
Impacted Files Coverage Δ
benchbuild/utils/actions.py 54.74% <86.95%> (-0.97%) ⬇️
benchbuild/environments/service_layer/ensure.py 63.63% <0.00%> (-18.19%) ⬇️
benchbuild/environments/service_layer/ui.py 57.14% <0.00%> (-14.29%) ⬇️
...enchbuild/environments/service_layer/messagebus.py 75.00% <0.00%> (-2.50%) ⬇️
benchbuild/environments/adapters/common.py 60.00% <0.00%> (-1.67%) ⬇️
benchbuild/environments/entrypoints/cli.py 85.52% <0.00%> (+1.31%) ⬆️
benchbuild/utils/download.py 22.56% <0.00%> (+4.87%) ⬆️
benchbuild/environments/domain/model.py 89.74% <0.00%> (+5.98%) ⬆️
...chbuild/environments/service_layer/unit_of_work.py 76.64% <0.00%> (+5.98%) ⬆️
benchbuild/environments/service_layer/handlers.py 86.79% <0.00%> (+16.98%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vulder vulder self-requested a review September 29, 2022 17:54
Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall stuff still runs

status: StepResult

def __init_subclass__(cls, **kwargs: tp.Any):
super().__init_subclass__(**kwargs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is no base class here, so super does not exist


StepTy_co = tp.TypeVar("StepTy_co", bound=Step, covariant=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want this still bound on Step?

Ok, from my side I have two "issues" here.
a) Protocols can only inherit protocols, so not Step
b) I change the call function

b -> I can fix by calling my function a different name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not necessarily.
This seems like a minimal patch to improve type-safety in utils/actions.py.

Removing the bound requires more changes by all MultiStep descendants:

  • Any
  • Experiment
  • RequireAll

I haven't actually thought about implementing them there yet, so that might be a minimal change as well.

@simbuerg simbuerg merged commit cc6f703 into master Oct 11, 2022
@simbuerg simbuerg deleted the simbuerg/fix-immutable-lists branch October 11, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants