Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(environments): warn the user that a project enumeration skipped a project #515

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

simbuerg
Copy link
Member

@simbuerg simbuerg commented Nov 7, 2022

A project will not be enumerated for project container image creation, if the container attribute of the project is an empty image.

We "fix" this by printing a message that hints at the problem.

@simbuerg simbuerg requested a review from vulder November 7, 2022 21:42
…a project

A project will not be enumerated for project container image creation, if the
container attribute of the project is an empty image.

We "fix" this by printing a message that hints at the problem.
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 52.23% // Head: 52.22% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (59c3b42) compared to base (14ff152).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
- Coverage   52.23%   52.22%   -0.02%     
==========================================
  Files         124      124              
  Lines        8304     8307       +3     
  Branches     1025     1025              
==========================================
  Hits         4338     4338              
- Misses       3789     3792       +3     
  Partials      177      177              
Impacted Files Coverage Δ
benchbuild/environments/entrypoints/cli.py 84.41% <0.00%> (-1.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simbuerg simbuerg merged commit 6323d77 into master Nov 8, 2022
@simbuerg simbuerg deleted the simbuerg/fix-no-warning-on-empty-container-decl branch November 8, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants