Add support for Yes/No/Cancel buttons #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opening this again because I accidentally closed #122 |
PolyMeilex
requested changes
Jun 28, 2023
Co-authored-by: Bartłomiej Maryńczak <marynczak.bartlomiej@gmail.com>
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81
I based this off of this fork: https://github.com/zphixon/rfd
The Yes/No/Cancel provided by the OS seem to work fine on Linux and macOS, however:
I addressed both of these issues and updated the documentation of
MessageDialogaccordingly.Tested on Windows and Linux (GTK3).
WASM, macOS and Linux (XDG) still need testing. Unfortunately, I don't have easy access to a Mac, so we'll need someone else who does to test this.