Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation rewrite #43

Merged
merged 1 commit into from
Jan 19, 2022
Merged

documentation rewrite #43

merged 1 commit into from
Jan 19, 2022

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jan 19, 2022 •
edited
Loading

  • Move most documentation to lib.rs so it will show up on docs.rs
  • Make examples build as doc tests
  • More details about GTK versus XDG Desktop Portal backends
  • Remove unneeded subsections in inline documentation
  • Consistent formating
  • Various edits for clarity

@Be-ing Be-ing force-pushed the docs branch 2 times, most recently from 51b097d to d6ef3df Compare January 19, 2022 06:03
@Be-ing Be-ing mentioned this pull request Jan 19, 2022
Merged
@Be-ing
documentation rewrite
b274ee2 
  * Move most documentation to lib.rs so it will show up on docs.rs
  * Make examples build as doc tests
  * More details about GTK versus XDG Desktop Portal backends
  * Remove unneeded subsections in inline documentation
  * Consistent formating
  * Various edits for clarity
@PolyMeilex
Copy link
Owner

Thanks!

@PolyMeilex PolyMeilex merged commit 8362047 into PolyMeilex:master Jan 19, 2022
@Be-ing Be-ing deleted the docs branch January 19, 2022 12:40
@Be-ing
Copy link
Contributor Author

Be-ing commented Jan 19, 2022

Could you make a 0.7.0 release now?

@Be-ing
Copy link
Contributor Author

Be-ing commented Jan 19, 2022

Wait, first -- @bilelmoussaoui, when are you planning to release ashpd 0.2.0? The master branch of rfd is currently using ashpd 0.2.0-beta1.

@bilelmoussaoui
Copy link
Contributor

In a week or so, depends on the potential issues found out there.

@Be-ing
Copy link
Contributor Author

Be-ing commented Jan 19, 2022

Okay, I think we should hold off from making a new rfd release until ashpd 0.2.0 is released. In the meantime I can use the master branch of rfd in my application.

@PolyMeilex
Copy link
Owner

Yep, in the meantime I'll do some additional testing, so when ashpd releases we should be good to go

@PolyMeilex PolyMeilex mentioned this pull request Mar 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Be-ing @PolyMeilex @bilelmoussaoui