Fixup clippy args #103
rust.yml
on: push
fmt
5s
clippy
41s
default-build
34s
no-default-build
21s
crossfont-build
47s
ab-glyph-build
34s
Annotations
13 errors and 32 warnings
used `expect()` on an `Option` value:
src/lib.rs#L538
error: used `expect()` on an `Option` value
--> src/lib.rs:538:32
|
538 | let mut mask = Mask::new(canvas_w as u32, canvas_h as u32)
| ________________________________^
539 | | .expect("Invalid mask width and height");
| |____________________________________________________________^
|
= help: if this value is `None`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_used
|
used `expect()` on an `Option` value:
src/lib.rs#L338
error: used `expect()` on an `Option` value
--> src/lib.rs:338:27
|
338 | let decorations = self
| ___________________________^
339 | | .decorations
340 | | .as_mut()
341 | | .expect("trying to resize the hidden frame.");
| |_________________________________________________________^
|
= help: if this value is `None`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_used
|
used `unwrap()` on a `Result` value:
src/title/ab_glyph_renderer.rs#L153
error: used `unwrap()` on a `Result` value
--> src/title/ab_glyph_renderer.rs:153:14
|
153 | _ => FontRef::try_from_slice(CANTARELL).unwrap(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: if this value is an `Err`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
|
used `unwrap()` on a `Result` value:
src/title/ab_glyph_renderer.rs#L151
error: used `unwrap()` on a `Result` value
--> src/title/ab_glyph_renderer.rs:151:37
|
151 | .unwrap_or_else(|_| FontRef::try_from_slice(CANTARELL).unwrap())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: if this value is an `Err`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
|
used `expect()` on an `Option` value:
src/title/ab_glyph_renderer.rs#L32
error: used `expect()` on an `Option` value
--> src/title/ab_glyph_renderer.rs:32:20
|
32 | let size = parse_font(&font)
| ____________________^
33 | | .pt_to_px_scale(font_pref_pt_size)
34 | | .expect("invalid font units_per_em");
| |________________________________________________^
|
= help: if this value is `None`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_used
= note: requested on the command line with `-D clippy::expect-used`
|
used `unwrap()` on an `Option` value:
src/parts.rs#L182
error: used `unwrap()` on an `Option` value
--> src/parts.rs:182:9
|
182 | self.surface.data::<SurfaceData>().unwrap().scale_factor() as u32
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: if this value is `None`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
= note: requested on the command line with `-D clippy::unwrap-used`
|
used `expect()` on an `Option` value:
src/lib.rs#L538
error: used `expect()` on an `Option` value
--> src/lib.rs:538:32
|
538 | let mut mask = Mask::new(canvas_w as u32, canvas_h as u32)
| ________________________________^
539 | | .expect("Invalid mask width and height");
| |____________________________________________________________^
|
= help: if this value is `None`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_used
|
used `expect()` on an `Option` value:
src/lib.rs#L338
error: used `expect()` on an `Option` value
--> src/lib.rs:338:27
|
338 | let decorations = self
| ___________________________^
339 | | .decorations
340 | | .as_mut()
341 | | .expect("trying to resize the hidden frame.");
| |_________________________________________________________^
|
= help: if this value is `None`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_used
|
used `unwrap()` on a `Result` value:
src/title/ab_glyph_renderer.rs#L153
error: used `unwrap()` on a `Result` value
--> src/title/ab_glyph_renderer.rs:153:14
|
153 | _ => FontRef::try_from_slice(CANTARELL).unwrap(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: if this value is an `Err`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
|
used `unwrap()` on a `Result` value:
src/title/ab_glyph_renderer.rs#L151
error: used `unwrap()` on a `Result` value
--> src/title/ab_glyph_renderer.rs:151:37
|
151 | .unwrap_or_else(|_| FontRef::try_from_slice(CANTARELL).unwrap())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: if this value is an `Err`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
|
used `expect()` on an `Option` value:
src/title/ab_glyph_renderer.rs#L32
error: used `expect()` on an `Option` value
--> src/title/ab_glyph_renderer.rs:32:20
|
32 | let size = parse_font(&font)
| ____________________^
33 | | .pt_to_px_scale(font_pref_pt_size)
34 | | .expect("invalid font units_per_em");
| |________________________________________________^
|
= help: if this value is `None`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_used
= note: requested on the command line with `-D clippy::expect-used`
|
used `unwrap()` on an `Option` value:
src/parts.rs#L182
error: used `unwrap()` on an `Option` value
--> src/parts.rs:182:9
|
182 | self.surface.data::<SurfaceData>().unwrap().scale_factor() as u32
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: if this value is `None`, it will panic
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
= note: requested on the command line with `-D clippy::unwrap-used`
|
clippy
Clippy had exited with the 101 exit code
|
fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
no-default-build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
no-default-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
no-default-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
no-default-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
no-default-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
this function has too many arguments (9/7):
src/buttons.rs#L116
warning: this function has too many arguments (9/7)
--> src/buttons.rs:116:5
|
116 | / pub fn draw(
117 | | &self,
118 | | start_x: f32,
119 | | end_x: f32,
... |
125 | | state: &WindowState,
126 | | ) {
| |______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
default-build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
default-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
default-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
default-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
default-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ab-glyph-build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
ab-glyph-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ab-glyph-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ab-glyph-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ab-glyph-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
this function has too many arguments (9/7):
src/buttons.rs#L116
warning: this function has too many arguments (9/7)
--> src/buttons.rs:116:5
|
116 | / pub fn draw(
117 | | &self,
118 | | start_x: f32,
119 | | end_x: f32,
... |
125 | | state: &WindowState,
126 | | ) {
| |______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
crossfont-build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
crossfont-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
crossfont-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
crossfont-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
crossfont-build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|