-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Version 3 / Vue3 Support #118
Conversation
Hi @lzurbriggen, Sorry for the delay… Thank you for your PR, but you probably should split this into a new package. I don't have time anymore to contribute to vue-gettext. In fact I haven't worked with Vue.js in over three years. I'm barely merging PR and keeping deps up to date. |
@kemar No problem, I'll probably do that soon. Thanks for the response! |
Just to link it here, this is the repo in mention: https://github.com/jshmrtn/vue3-gettext Thanks for your hard work! |
@Knogobert thanx, I'll put a link in the README asap |
I'm working on Vue3 support.
This is a work in progress and not ready to be merged yet. I'm making relatively drastic changes and I'd appreciate some feedback/discussion. If we disagree on the direction this is taking I could split this into a new package.
changes on the dev side
npm run dev
now runs a Vue3 project usingvite
(no more webpack)localVue
; the plugin instance is passed around as a function argumentchanges on user side
useGettext()
function, e.g.useGettext().current = 'en_US'
Vue.config
. Vue3 hasapp.config
but I'm not sure if it's best practice to populate that object. For now the config can be accessed via$language.options
autoAddKeyAttributes
, likely unnecessarytodo
@vue/test-utils
when it has released a new version including my changes to the plugin api (should fix most tests)easygettext
)