Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on Vue3 support.
This is a work in progress and not ready to be merged yet. I'm making relatively drastic changes and I'd appreciate some feedback/discussion. If we disagree on the direction this is taking I could split this into a new package.
changes on the dev side
npm run dev
now runs a Vue3 project usingvite
(no more webpack)localVue
; the plugin instance is passed around as a function argumentchanges on user side
useGettext()
function, e.g.useGettext().current = 'en_US'
Vue.config
. Vue3 hasapp.config
but I'm not sure if it's best practice to populate that object. For now the config can be accessed via$language.options
autoAddKeyAttributes
, likely unnecessarytodo
@vue/test-utils
when it has released a new version including my changes to the plugin api (should fix most tests)easygettext
)