Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] m31 exp #96

Merged
merged 2 commits into from
Sep 24, 2024
Merged

[FIX] m31 exp #96

merged 2 commits into from
Sep 24, 2024

Conversation

enpsi20481
Copy link
Contributor

Fixes a bug in <M31 as Field>::exp, adds test vectors that catch the error.

@zhenfeizhang zhenfeizhang merged commit 1b12982 into PolyhedraZK:main Sep 24, 2024
10 of 11 checks passed
niconiconi added a commit that referenced this pull request Sep 24, 2024
* [FIX] m31 exp (#96)

* chore: test vectors for M31

* fix: M31 exponentiation

---------

Co-authored-by: enpsi <enpsi20482@gmail.com>

* fix ci (#104)

---------

Co-authored-by: 0xwework <enpsi20481@gmail.com>
Co-authored-by: enpsi <enpsi20482@gmail.com>
Co-authored-by: zhenfei <zhenfei.zhang@hotmail.com>
niconiconi added a commit that referenced this pull request Sep 25, 2024
* draft v1

* clippy

* correctness

* fmt

* clippy

* add mpi finalize

* clippy

* refactor; try make mpi compatible with threading

* add finalize

* clippy

* try ci install

* update

* try mpi install

* try mpi install

* try mpi install

* try mpi install

* refactor

* clippy

* identify structure info

* clippy

* main-mpi

* mpi_config

* mpiexec in ci

* intentially fail ci for mpi

* now correct

* minor in toml

* Update ci.yml

Signed-off-by: Tiancheng Xie <tc@polyhedra.network>

* allow static mut ref

* Update build.yml

Signed-off-by: Tiancheng Xie <tc@polyhedra.network>

* Update ci.yml

Signed-off-by: Tiancheng Xie <tc@polyhedra.network>

* Merge CI change (#106)

* [FIX] m31 exp (#96)

* chore: test vectors for M31

* fix: M31 exponentiation

---------

Co-authored-by: enpsi <enpsi20482@gmail.com>

* fix ci (#104)

---------

Co-authored-by: 0xwework <enpsi20481@gmail.com>
Co-authored-by: enpsi <enpsi20482@gmail.com>
Co-authored-by: zhenfei <zhenfei.zhang@hotmail.com>

---------

Signed-off-by: Tiancheng Xie <tc@polyhedra.network>
Co-authored-by: Tiancheng Xie <tc@polyhedra.network>
Co-authored-by: 0xwework <enpsi20481@gmail.com>
Co-authored-by: enpsi <enpsi20482@gmail.com>
Co-authored-by: zhenfei <zhenfei.zhang@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants