-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTM logic refactored #572
GTM logic refactored #572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach is good on the contract side but it will little bit harden the dApp work. dApp team needs to create some scenarios (combination of true or false) when issuer wants to change in the transfers flag.
And redemption/ allowAllWhitelistTransfers will little bit costlier.
contracts/modules/TransferManager/GTM/GeneralTransferManager.sol
Outdated
Show resolved
Hide resolved
@satyamakgec Only |
GTM logic has been simplified and made more flexible.
Some work will be required by the dApp team to incorporate the changes.