This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Make sure inlined style imports are ordered correctly #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `<link rel="import" type="css">` styles were inlined by prepending to the top of the `<dom-module>` template. However, if there were multiple imports, the order would be reversed, which can cause incorrect styling when overriding. This commit makes sure the order remains correct for multiple style imports. Fixes #575
kevinpschaaf
reviewed
Jul 7, 2017
| this.prepend(domTemplate.childNodes[0], style); | ||
| } else { | ||
| // put this style behind the last polymer external style | ||
| dom5.insertBefore(domTemplate.childNodes[0], nextSibling(lastPolymerExternalStyle), style); |
There was a problem hiding this comment.
Seems like it would be easier to have the promises resolve with the style, and then in the then take the array of styles from Promise.all and append them in one go?
Or else just reverse the array of links to make inserting easier.
There was a problem hiding this comment.
I'm really not inclined to go refactor this deprecated branch too much.
|
I thought the |
|
@stramel deprecated, but not removed for Polymer 1.x, nor for 2.x. |
kevinpschaaf
approved these changes
Jul 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
<link rel="import" type="css">styles were inlined byprepending to the top of the
<dom-module>template.However, if there were multiple imports, the order would be reversed,
which can cause incorrect styling when overriding.
This commit makes sure the order remains correct for multiple style
imports.
Fixes #575