Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about missing property which is inherited from composed behavior #1018

Closed
web-padawan opened this issue Mar 31, 2017 · 4 comments
Closed

Comments

@web-padawan
Copy link
Contributor

When linting a project with iron-lazy-pages element I noticed that linter doesn't recognize property selected which is inherited from IronSelectableBehavior here:

          selected="[[subPage]]"
          ~~~~~~~~

src/components/pages/sandbox-demo-page/sandbox-demo-page.html(29,10)  
warning [set-unknown-attribute] - iron-lazy-pages elements do not have a property named selected.
Consider instead:  spellcheck

Steps to reproduce:

  • git clone https://github.com/web-padawan/polymer-sandbox
  • git checkout linter-sandbox
  • npm i && bower i && npm run lint:polymer

I don't get any warnings like this when linting iron-lazy-pages itself.

rictic referenced this issue in rictic/iron-lazy-pages Mar 31, 2017
By explicitly having the name on the Impl, the analyzer was taking the annotation at its word, but missing that it used IronSelectableBehavior.

Fixes https://github.com/Polymer/polymer-linter/issues/70
@rictic
Copy link
Contributor

rictic commented Mar 31, 2017

I think the root cause here is the way the @polymerBehavior annotation is written in iron-lazy-pages. Sent TimvdLippe/iron-lazy-pages#51 out to fix

TimvdLippe referenced this issue in TimvdLippe/iron-lazy-pages Mar 31, 2017
By explicitly having the name on the Impl, the analyzer was taking the annotation at its word, but missing that it used IronSelectableBehavior.

Fixes https://github.com/Polymer/polymer-linter/issues/70
@TimvdLippe
Copy link
Contributor

Sorry! Fix has been merged ❤️

@web-padawan
Copy link
Contributor Author

Thanks for quick fix!

@TimvdLippe
Copy link
Contributor

@aomarks aomarks transferred this issue from Polymer/polymer-linter Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants