This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
🐐 Bring more inline with gulp best practices #385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samccone
force-pushed
the
gulp-best-practive
branch
from
8aab28b
to
0db190d
Compare
|
Reviewed. |
samccone
force-pushed
the
gulp-best-practive
branch
from
0db190d
to
2df8b96
Compare
|
updated! |
| @@ -49,6 +49,50 @@ var styleTask = function (stylesPath, srcs) { | |||
| .pipe($.size({title: stylesPath})); | |||
| }; | |||
|
|
|||
| var jshintTask = function (src) { | |||
| return gulp.src(src) | |||
| .pipe(reload({stream: true, once: true})) | |||
There was a problem hiding this comment.
Hey, it seems to me that you are reintroducing the double reload that was removed as per PR #370, is that intended?
There was a problem hiding this comment.
I just need to rebase and it should go away (unless Git gets really confused)👌 good spot though I will doubly make sure it gets removed!
samccone
force-pushed
the
gulp-best-practive
branch
2 times, most recently
from
395e925
to
6bd6cf5
Compare
|
yep it went away @didrocks :) |
|
@samccone great! thanks for confirming ;) |
|
Tried running locally again. Looks like we're now breaking on the HTML task and are running into some linting issues: |
Extract non-specific tasks to fns to be more inline with "the gulp way✨" Fixes #289
samccone
force-pushed
the
gulp-best-practive
branch
from
6bd6cf5
to
c6bbc6e
Compare
|
should be GTG now 🏁 |
|
Tested again and everything is passing now. Have some 🍰! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract non-specific tasks to fns to be more inline with "the gulp way✨"
Fixes #289