Merge pull request #1600 from Polymer/1573-kschaaf

Notify array.length changes. Fixes #1573.
Polymer · May 23, 2015 · 3b1d038 · 3b1d038
2 parents 9ea9d8e + 0a06a72
commit 3b1d038
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/src/standard/notify-path.html b/src/standard/notify-path.html
@@ -290,6 +290,9 @@
           indexSplices: splices
         };
         this.set(path + '.splices', change);
+        if (added != removed.length) {
+          this.notifyPath(path + '.length', array.length);
+        }
         // Null here to allow potentially large splice records to be GC'ed
         change.keySplices = null;
         change.indexSplices = null;

diff --git a/test/unit/notify-path-elements.html b/test/unit/notify-path-elements.html
@@ -101,7 +101,7 @@
   <x-basic id="basic" notifying-value="{{nested.obj.value}}" attrvalue$="{{nested.obj.value}}"></x-basic>
   <x-compose id="compose" obj="{{nested.obj}}"></x-compose>
   <x-forward id="forward" obj="{{nested.obj}}"></x-forward>
-  <div id="boundChild" computed-from-paths="{{computeFromPaths(a, nested.b, nested.obj.c)}}"></div>
+  <div id="boundChild" computed-from-paths="{{computeFromPaths(a, nested.b, nested.obj.c)}}" array-length="{{data.length}}"></div>
 </template>
 <script>
   Polymer({

diff --git a/test/unit/notify-path.html b/test/unit/notify-path.html
@@ -747,6 +747,25 @@
     assert.equal(el.observerCounts.arrayOrPropChanged, 1);
   });
 
+  test('array.length notified', function() {
+    el.data = [];
+    assert.equal(el.$.boundChild.arrayLength, el.data.length);
+    el.push('data', 1, 2, 3);
+    assert.equal(el.$.boundChild.arrayLength, el.data.length);
+    el.pop('data');
+    el.pop('data');
+    assert.equal(el.$.boundChild.arrayLength, el.data.length);
+    el.unshift('data', 1, 2);
+    el.unshift('data', 1, 2, 3);
+    assert.equal(el.$.boundChild.arrayLength, el.data.length);
+    el.splice('data', 2, 2, 1, 2, 3);
+    assert.equal(el.$.boundChild.arrayLength, el.data.length);
+    el.shift('data');
+    el.shift('data');
+    el.shift('data');
+    assert.equal(el.$.boundChild.arrayLength, el.data.length);
+  });
+
 });
 
 suite('path API', function() {