For consistency, make sure Polymer.dom(node).childNodes always return…

…s an array. Helps address #1367.
Polymer · Apr 9, 2015 · 82882e6 · 82882e6
1 parent ba365fc
commit 82882e6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/lib/dom-api.html b/src/lib/dom-api.html
@@ -46,7 +46,8 @@
       },
 
       get childNodes() {
-        return getLightChildren(this.node);
+        var c$ = getLightChildren(this.node);
+        return Array.isArray(c$) ? c$ : Array.prototype.slice.call(c$);
       },
 
       get children() {
@@ -396,9 +397,8 @@
           }
           n = n.parentNode;
         }
-
       };
-      
+
     }
 
     var CONTENT = 'content';

diff --git a/test/unit/polymer-dom.js b/test/unit/polymer-dom.js
@@ -293,4 +293,8 @@ suite('Polymer.dom', function() {
     assert.equal(eventHandled, 2);
   });
 
+  test('Polymer.dom.childNodes is an array', function() {
+    assert.isTrue(Array.isArray(Polymer.dom(document.body).childNodes));
+  });
+
 });