Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs examples missing custom element name #1058

Closed
caiowilson opened this issue Dec 30, 2014 · 3 comments
Closed

Docs examples missing custom element name #1058

caiowilson opened this issue Dec 30, 2014 · 3 comments

Comments

@caiowilson
Copy link

well, this is not a bug per se, more of an issue and it's not solely about one page. The thing is that since under polyfills (firefox actually - guess gecko is mainly what polyfills are supposed to be targeting - ) you can't omit the element name on calling Polymer(); you shouldn't really throw examples like that, it leads to bugs that are kinda hard to realise and further difficult the dev's life. just my two cents. close it if you don't agree and want to tell me to fuck off. @arthurevans @ebidel @robdodson (sorry about tagging everyone quite haven't figured out who's responsible for what yet. oh and i hate capitalising proper nouns.

@ebidel
Copy link
Contributor

ebidel commented Dec 30, 2014

When you omit the element name to Polymer(), we still use the one declared
on polymer-element to call document. registerElement with. That will work
under the polyfill and is what many of the elements do.
On Dec 30, 2014 9:08 AM, "caiowilson" notifications@github.com wrote:

well, this is not a bug per se, more of an issue and it's not solely about
one page. The thing is that since under polyfills (firefox actually - guess
gecko is mainly what polyfills are supposed to be targeting - ) you can't
omit the element name on calling Polymer(); you shouldn't really throw
examples like that, it leads to bugs that are kinda hard to realise and
further difficult the dev's life. just my two cents. close it if you don't
agree and want to tell me to fuck off. @arthurevans
https://github.com/arthurevans @ebidel https://github.com/ebidel
@robdodson https://github.com/robdodson (sorry about tagging everyone
quite haven't figured out who's responsible for what yet. oh and i have
capitalising proper nouns.


Reply to this email directly or view it on GitHub
#1058.

@arthurevans
Copy link

Hey @caiowilson where are you seeing this? It can be a problem if the Polymer() call occurs outside of the polymer-element. But it should work the same on all browsers. If there's a firefox-specific problem, that's a bug.

The duplicate element name also caused problems -- because people would remember to change it in one place but not the other. That's why we moved away from using it in examples.

@caiowilson
Copy link
Author

didn't thought of the duplicate names, i guess its better off that way. but i am not sure how's it working now. last month i had to change a lot of noscript elements to normal ones and add the explicit name calling Polymer() or firefox would spit in my face. not nice, this fella. then again, i am on "aurora", dev, nightly whatever mozilla decides to call this week their nightly builds. so it was probably then the case of a firefox bug assuming @ebidel is correct. thank you guys once again. i'll try removing it again and if everything explodes i'll reopen it. closing. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants