Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.3] Do not resolve hash-only urls used for routing #1757

Closed
nippur72 opened this issue Jun 5, 2015 · 1 comment · Fixed by #1780
Closed

[1.0.3] Do not resolve hash-only urls used for routing #1757

nippur72 opened this issue Jun 5, 2015 · 1 comment · Fixed by #1780
Assignees
Labels

Comments

@nippur72
Copy link
Contributor

nippur72 commented Jun 5, 2015

I think the error #651 that was fixed in 0.5 is back in 1.0.

I have an my-element.html that defines:

<a href="#del"></a>

but in the browser it's converted to my-element.html#del.

@nippur72
Copy link
Contributor Author

nippur72 commented Jun 8, 2015

I wonder if it's the case of avoiding resolution for urls starting with / too, like we had in 0.5:

polymer/src/lib/url.js

Lines 99 to 101 in c716964

// do not resolve '/' absolute urls
if (url && url[0] === '/') {
return url;

dfreedm added a commit that referenced this issue Jun 8, 2015
Fixes #1757, do not resolve hash-only urls used for routing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants