Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifyPath doesn't return as its documentation says #1966

Closed
zacharytamas opened this issue Jun 25, 2015 · 2 comments
Closed

notifyPath doesn't return as its documentation says #1966

zacharytamas opened this issue Jun 25, 2015 · 2 comments
Assignees
Labels

Comments

@zacharytamas
Copy link

I've been running into lots of problems lately and have been trying to use notifyPath to test things and have found that it actually doesn't behave like its documentation says.

The documentation says that it returns true if the notification actually happens but if you look at the source code, it never actually returns anything and is always undefined.

This isn't very helpful from a debugging standpoint and is also inconsistent with what the API Reference says (because this is auto-generated from the source code comment which is incorrect).

It would be nice if we could get a return true as the documentation states. In my case, my calls to notifyPath where not actually causing events but it was hard to determine that.

@kevinpschaaf
Copy link
Member

PR: #1991

@zacharytamas
Copy link
Author

Thanks @kevinpschaaf

kevinpschaaf added a commit that referenced this issue Jul 2, 2015
Add return value and update docs.  Fixes #1966.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants