Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low-level changes for iron-list integration (fire & modelForElement) #2003

Closed
kevinpschaaf opened this issue Jul 1, 2015 · 0 comments
Closed

Low-level changes for iron-list integration (fire & modelForElement) #2003

kevinpschaaf opened this issue Jul 1, 2015 · 0 comments
Assignees
@kevinpschaaf
Labels
p1

Comments

@kevinpschaaf
Copy link
Member

Need two changes for iron-list integration:

  • Polymer.Bind lib has a layering violation (noted TODO) where it calls this.fire from Bind. Should be changed to call Polymer.Base.fire, so that the model API decoupled (iron-list prepares the vanilla template as a bind model, which is not a Polymer.Base extension)
  • Since Templatizer performs the _templateInstance decoration of top-level stamped children, modelForElement should be a Templatizer API since it relies on this implementation detail.
@sujkh85 sujkh85 mentioned this issue Jul 1, 2015
Merged
@kevinpschaaf kevinpschaaf self-assigned this Jul 1, 2015
@kevinpschaaf kevinpschaaf added the p1 label Jul 1, 2015
sorvell pushed a commit that referenced this issue Jul 6, 2015
Merge pull request #2004 from Polymer/2003-kschaaf-model-fire
5beaf03 
Move modelForElement to Templatizer, use Polymer.Base.fire in Bind lib. Fixes #2003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinpschaaf kevinpschaaf

Labels
p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinpschaaf