Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymer events creates a new bound handler for every listen call #2534

Closed
cdata opened this issue Oct 6, 2015 · 4 comments
Closed

Polymer events creates a new bound handler for every listen call #2534

cdata opened this issue Oct 6, 2015 · 4 comments
Assignees
@dfreedm

Comments

@cdata
Copy link
Contributor

cdata commented Oct 6, 2015

As discussed in person, this could be made slightly more optimal by looking to see if a listener has been created already.

Fixing this would allow listen to be called n times with the same arguments, while ensuring that only one listener is ever actually added.
@cdata
Copy link
Contributor Author

cdata commented Oct 6, 2015

This bugfix blocks makes the fix uglier for PolymerElements/iron-selector#64

@dfreedm
Copy link
Member

dfreedm commented Oct 6, 2015

This is a bug in events module, not in gestures.

dfreedm added a commit that referenced this issue Oct 6, 2015
@dfreedm
Only one real listener per listen call
8bd380a 
Actually use event listener cache correctly

Fixes #2534 Polymer Gestures creates a new bound handler for every `listen` call
@dfreedm dfreedm mentioned this issue Oct 6, 2015
Merged
@cdata cdata changed the title Polymer Gestures creates a new bound handler for every listen call Polymer events creates a new bound handler for every listen call Oct 6, 2015
@cdata
Copy link
Contributor Author

cdata commented Oct 6, 2015

Amended the title.

@cdata
Copy link
Contributor Author

cdata commented Oct 6, 2015

We merged a temporary patch to IronSelectable where we do our own book-keeping. When this is closed, we should go back and clean up the extra book keeping in PolymerElements/iron-selector#70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreedm dfreedm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfreedm @cdata