Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using native CustomElements and ShadowDOM polyfill together may cause unwanted attached/detached callbacks being called #399

Closed
frankiefu opened this issue Jan 21, 2014 · 2 comments
Closed

Using native CustomElements and ShadowDOM polyfill together may cause unwanted attached/detached callbacks being called #399

frankiefu opened this issue Jan 21, 2014 · 2 comments

Comments

@frankiefu
Copy link
Member

attached/detatchedCallbacks are called natively so that's whenever ShadowDOM polyfill moves stuff around and generally way too much.

We can just make CE not 'useNative' if SD polyfill is in effect.
@sorvell
Copy link
Contributor

sorvell commented Jan 21, 2014

Yes, we'll make CustomElements default to polyfill in the presence of SD polyfill. We can address this more directly if the need arises.

sorvell added a commit to googlearchive/CustomElements that referenced this issue Jan 21, 2014
@sorvell
Helps address Polymer/polymer#399
7266eba
@sorvell
Copy link
Contributor

sorvell commented Aug 11, 2014

platform.js now defaults to CustomElements polyfill in the presence of ShadowDOM polyfill.

@sorvell sorvell closed this as completed Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sorvell @frankiefu