Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.8] Fix bespoke element constructors #1152

Closed
wants to merge 1 commit into from
Closed

[0.8] Fix bespoke element constructors #1152

wants to merge 1 commit into from

Conversation

peterwmwong
Copy link
Contributor

Fixes #1151

@addyosmani
Copy link
Member

cc @sjmiles @kevinpschaaf

@peterwmwong peterwmwong mentioned this pull request Feb 20, 2015
Closed
@sorvell sorvell added 0.8 and removed 0.8 labels Mar 5, 2015
@kevinpschaaf kevinpschaaf mentioned this pull request Mar 9, 2015
Closed
@kevinpschaaf
Copy link
Member

Fixed in 24a2914 (didn't take PR #1152 as the implementation has changed a bit). Note the API change, such that the custom constructor need not call document.createElement and return the element. This will be done automatically; the user constructor should only configure the instance (this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.8 cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterwmwong @addyosmani @kevinpschaaf @sorvell @googlebot