Separate attributes function from annotations #1296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/features/micro/attributes.html src/features/standard/notify-path.html
Conflicts: test/unit/attributes.html
|
Great catch! These commits were cherry-picked into #1300 and merged there. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is repeated pull request, after rebase upstream branch.
Original vulcanized polymer-micro and polymer-mini has size 10 kb and 30 kb. After merge my pull request vulcanized polymer-micro and polymer-mini will have size 6 kb and 26 kb.
It is not good idea include all
annotationsfeatures in polymer-micro and polymer-mini, i think.@kevinpschaaf, @sorvell, @nevir, @sjmiles, @ebidel, can you comment?