Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8 gestures #1309

Merged
merged 3 commits into from
Mar 19, 2015
Merged

0.8 gestures #1309

merged 3 commits into from
Mar 19, 2015

Conversation

frankiefu
Copy link
Member

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

frankiefu added a commit that referenced this pull request Mar 19, 2015
@frankiefu frankiefu merged commit b3be14e into 0.8-preview Mar 19, 2015
@arthurevans
Copy link

What did we just add here? And is this in 0.8, or post-0.8?

@frankiefu
Copy link
Member Author

This is wip gestures system (currently on-tap and on-track are somewhat supported). @azakus will continue to work it next week. My understanding is this is not part of the 0.8 official release. @sorvell can confirm.

@dfreedm dfreedm deleted the 0.8-gestures branch April 2, 2015 00:26
@peterwmwong
Copy link
Contributor

FYI - I noticed that the track gesture introduced in this PR breaks touch scrolling. PolymerElements/paper-drawer-panel content cannot be scrolled on mobile devices because the track gesture is calling preventDefault() on touch move here.

Reduction: http://jsbin.com/wocoba/12/edit?html,output vs http://jsbin.com/wocoba/13/edit?html,output

@dfreedm
Copy link
Member

dfreedm commented May 6, 2015

This should be addressed by the complete gestures rewrite in #1486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants