use `hasOwnProperty` to avoid overwriting prototype methods when mixing in behaviors (+test) #1473

sjmiles · 2015-04-30T20:04:07Z

No description provided.

…en by behaviors; prep own-behavior (prototype) last

…methods

sorvell · 2015-04-30T20:14:57Z

LGTM

use `hasOwnProperty` to avoid overwriting prototype methods when mixing in behaviors (+test)

Scott J Miles added 4 commits April 30, 2015 12:31

use hasOwnProperty to protect prototype methods from being overridd…

6745013

…en by behaviors; prep own-behavior (prototype) last

add behaviors test suite to runner

f1214a2

add test to ensure prototype-methods are not overwritten by behavior …

6669671

…methods

run behaviors test closer to 'micro' tests, since it's low-level

260dfdd

googlebot added the cla: yes label Apr 30, 2015

sorvell pushed a commit that referenced this pull request Apr 30, 2015

Merge pull request #1473 from Polymer/0.8-behaviors-first

bcd2923

use `hasOwnProperty` to avoid overwriting prototype methods when mixing in behaviors (+test)

sorvell merged commit bcd2923 into 0.8-preview Apr 30, 2015

sjmiles deleted the 0.8-behaviors-first branch May 1, 2015 08:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use `hasOwnProperty` to avoid overwriting prototype methods when mixing in behaviors (+test) #1473

use `hasOwnProperty` to avoid overwriting prototype methods when mixing in behaviors (+test) #1473

sjmiles commented Apr 30, 2015

sorvell commented Apr 30, 2015

use hasOwnProperty to avoid overwriting prototype methods when mixing in behaviors (+test) #1473

use hasOwnProperty to avoid overwriting prototype methods when mixing in behaviors (+test) #1473

Conversation

sjmiles commented Apr 30, 2015

sorvell commented Apr 30, 2015

use `hasOwnProperty` to avoid overwriting prototype methods when mixing in behaviors (+test) #1473

use `hasOwnProperty` to avoid overwriting prototype methods when mixing in behaviors (+test) #1473