Fix translate3d call after transform refactor #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {number} x X offset. | ||
| * @param {number} y Y offset. | ||
| * @param {number} z Z offset. | ||
| * @param {HTMLElement} node Optional Element to apply the transform to. |
There was a problem hiding this comment.
For optional arguments, you can call that out via the type expression via a trailing =:
@param {HTMLElement=} node Element to apply the transform to.
There was a problem hiding this comment.
We should go over the whole codebase. There are plenty of "Optional in description only" type expressions. I'll fix them for this PR, just noting for future reference.
dfreedm
force-pushed
the
translate3d-refactor
branch
from
d15fac2
to
85bcb13
Compare
kevinpschaaf
added a commit
that referenced
this pull request
May 2, 2015
Fix translate3d call after transform refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.