Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dom-if hidden state is (this._hideTemplateChildren || !this.if). #1635

Merged
merged 1 commit into from
Jun 4, 2015
Merged

dom-if hidden state is (this._hideTemplateChildren || !this.if). #1635

merged 1 commit into from
Jun 4, 2015

Conversation

kevinpschaaf
Copy link
Member

Fixes #1632.

@kevinpschaaf kevinpschaaf mentioned this pull request May 27, 2015
Closed
@sorvell
Copy link
Contributor

sorvell commented Jun 4, 2015

We don't handle the case of a dom-repeat stamping into a hidden dom-if. Will handle this via a separate issue.

@sorvell
Copy link
Contributor

sorvell commented Jun 4, 2015

LGTM.

sorvell pushed a commit that referenced this pull request Jun 4, 2015
Merge pull request #1635 from Polymer/1632-kschaaf
d96040c 
dom-if hidden state is (this._hideTemplateChildren || !this.if).
@sorvell sorvell merged commit d96040c into master Jun 4, 2015
@sorvell sorvell deleted the 1632-kschaaf branch June 4, 2015 21:56
@kevinpschaaf kevinpschaaf mentioned this pull request Jun 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sorvell sorvell

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[0.9.4] Nested dom-if templates show invalid content
3 participants
@kevinpschaaf @sorvell @googlebot