Make sure updateStyles works based on changes to customStyles and enhance api. #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t changes to customStyle are recognized. Fixes #1915: Include a `customStyleProperties` argument to `updateStyles` for convenience.
| this._properties = null; | ||
| if (properties) { | ||
| Polymer.Base.mixin(this.customStyle, properties); | ||
| } | ||
| // invalidate the cache | ||
| this._styleCache.clear(); |
There was a problem hiding this comment.
Users have reported on #1851 (comment) that Uncaught TypeError: Cannot read property 'clear' of undefined can be thrown if updateStyles is called too early. Should this just be guarded on this._styleCache being defined? Or is this handled elsewhere?
added 4 commits
June 23, 2015 09:40
|
LGTM. |
kevinpschaaf
added a commit
that referenced
this pull request
Jun 23, 2015
Make sure updateStyles works based on changes to customStyles and enhance api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1851: Include
customStylein the style host cache key so that changes to customStyle are recognized.Fixes #1915: Include a
customStylePropertiesargument toupdateStylesfor convenience.