Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disambiguate config fromAbove and local defaults, pass to _setProperty. #1940

Merged
merged 1 commit into from
Jun 23, 2015
Merged

Disambiguate config fromAbove and local defaults, pass to _setProperty. #1940

merged 1 commit into from
Jun 23, 2015

Conversation

kevinpschaaf
Copy link
Member

@kevinpschaaf
Disambiguate config fromAbove and local defaults, pass to _setProperty.
c7fec1c 
- Fixes bug in previous fix for #1839/#1854 where notifying properties would not notify during configuration
- renames `_setPropertyQuiet` to `_setProperty` with `quiet` arg
- renames `_propertySet` to `_propertySetter` for clarity
@sorvell
Copy link
Contributor

sorvell commented Jun 23, 2015

LGTM

sorvell pushed a commit that referenced this pull request Jun 23, 2015
Merge pull request #1940 from Polymer/1839-1854-cont-kschaaf
f62a80d 
Disambiguate config fromAbove and local defaults, pass to _setProperty.
@sorvell sorvell merged commit f62a80d into master Jun 23, 2015
@sorvell sorvell deleted the 1839-1854-cont-kschaaf branch June 23, 2015 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinpschaaf @sorvell @googlebot