Use single-property observer to deal better with if=undefined. Fixes #1742 #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1742 This takes advantage of the fact that single property observers are called for each change (including undefined), whereas multi-property observers wait for all properties to be defined. Since the side-effect of the observe is to queue an async render, there is no real benefit from this being a multi-property observer. #1946 is open to track a more general fix for this issue.
kevinpschaaf
changed the title
|
Needs a test. |
|
LGTM |
sorvell
pushed a commit
that referenced
this pull request
Jun 24, 2015
Use single-property observer to deal better with if=undefined. Fixes #1742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of the fact that single property observers are called for each change (including undefined), whereas multi-property observers wait for all properties to be defined. Since the side-effect of the observe is to queue an async render, there is no real benefit from this being a multi-property observer. #1946 is open to track a more general fix for this issue.