Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC for removing gray overlays on ios #1983

Merged
merged 2 commits into from
Jun 30, 2015
Merged

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented Jun 29, 2015

Fixes #1970

@dfreedm
Copy link
Member Author

dfreedm commented Jun 29, 2015

Tested on iOS simulator, seems to work as expected :)

@blasten
Copy link
Contributor

blasten commented Jun 30, 2015

LGTM. thanks for the fix!

@kevinpschaaf
Copy link
Member

Confirmed Android has similar highlight behavior with mouse events; pending update to add similar treatment for Android Chrome.

@MarkDurbin104
Copy link

I don't know if this CSS helps:
* { -webkit-tap-highlight-color: rgba(0, 0, 0, 0); }

@dfreedm
Copy link
Member Author

dfreedm commented Jun 30, 2015

@MarkDurbin104 the android issue is actually only caused by cursor: pointer. Then the webkit-tap-highlight-color trick is necessary to remove the highlight.

@kevinpschaaf
Copy link
Member

Reviewed, LGTM.

kevinpschaaf added a commit that referenced this pull request Jun 30, 2015
POC for removing gray overlays on ios
@kevinpschaaf kevinpschaaf merged commit b9c59f4 into master Jun 30, 2015
@kevinpschaaf kevinpschaaf deleted the 0.9-ios-only-touch branch June 30, 2015 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants