Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using value$ on input element #2673

Merged
merged 1 commit into from
Nov 18, 2015

Conversation

TimvdLippe
Copy link
Contributor

The error was thrown because of a specific edge case for <input value$="">. This check was introduced in #1589 for #1578 and latest modified on a300862#diff-870cfe064a36c23b69e8da891fdff6beR299

For both value$ and value name === 'value'. However, if it was originally value$ it should not be executed. Therefore the check should be changed to origName === 'value'.

Fixes #2666

@TimvdLippe TimvdLippe force-pushed the input-value-annotated branch from 0f0ece1 to 05a1e95 Compare November 3, 2015 12:02
@jmcgdz
Copy link

jmcgdz commented Nov 5, 2015

👍

1 similar comment
@justjico
Copy link

justjico commented Nov 5, 2015

👍

@liuwenchao
Copy link

👍

@varun-aggarwal
Copy link

👍

@sky-dev
Copy link

sky-dev commented Nov 13, 2015

👍

@kevinpschaaf
Copy link
Member

LGTM. 👍

Thanks @JeremybellEU!

kevinpschaaf added a commit that referenced this pull request Nov 18, 2015
@kevinpschaaf kevinpschaaf merged commit cfa6d51 into Polymer:master Nov 18, 2015
@TimvdLippe TimvdLippe deleted the input-value-annotated branch November 18, 2015 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants