Fix compound bindings with braces in literals

[TimvdLippe]

The problem in this regex was the [^}\]]* which also triggers on a single }. Therefore we have to check for a group of two } or ]. This is now changed to a negative look-ahead ?! which checks for \}\} and \]\]. After that the rest of the matches are non-greedy, to prevent double consuming of {{binding1}}{{binding2}} to be translated into a binding with variable name binding1}}{{binding2.

I also escaped all } and ] to force matching on literal characters.

Fixes #2704

[samccone]

wow.. you are too fast @JeremybellEU :)

[samccone]

cc @kevinpschaaf @ebidel for 👀

[kevinpschaaf]

LGTM 👍

[david-saslawsky]

@JeremybellEU many thanks for the fix.

Shouldn't the same solution be applied to the ([^{[]*) at the beginning ? Not very likely I know, but I'm thinking of cases like this one:

<span>[YES]/[NO] {{computeCompound('world', 'username ', 'Hello {0} ')}}</span>

Also, how does the negative lookahead works ? I might be missing something but it seems to me that the regexp works fine without it because of the non greedy match on (.+?):

/([^{[]*)(\{\{|\[\[)(.+?)(?:\]\]|\}\})/g

Anyway, thanks again. I can remove ugly workarounds in my application now 👍