Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event bindings #328

Merged
merged 12 commits into from
Oct 24, 2013
Merged

Event bindings #328

merged 12 commits into from
Oct 24, 2013

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented Oct 23, 2013

Use data binding to express event handlers.
This is a breaking change to event handler syntax, but allows for listening to non-bubbling events (like focus and blur) and simpler event processing.

In addition, the ready callback returns and the created callback will now fire at createdCallback time, before the ShadowRoot is created. Current and future element should use ready.

@dfreedm
Copy link
Member Author

dfreedm commented Oct 23, 2013

This also removes the enteredDocument and leftDocument callbacks, and forces use of enteredView and leftView callbacks instead.

dfreedm added a commit that referenced this pull request Oct 24, 2013
@dfreedm dfreedm merged commit b720085 into master Oct 24, 2013
JamesXNelson pushed a commit to sdbg/sdbg that referenced this pull request Jan 28, 2014
we're still missing a few commits (such as Polymer/polymer#328) but this gets us pretty close to fixing https://code.google.com/p/dart/issues/detail?id=14377

R=sigmund@google.com

Review URL: https://codereview.chromium.org//30183005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@29192 260f80e4-7a28-3924-810f-c04153c831b5
svn2github pushed a commit to svn2github/dart-lang that referenced this pull request Jul 15, 2014
we're still missing a few commits (such as Polymer/polymer#328) but this gets us pretty close to fixing https://code.google.com/p/dart/issues/detail?id=14377

R=sigmund@google.com

Review URL: https://codereview.chromium.org//30183005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@29192 260f80e4-7a28-3924-810f-c04153c831b5
jmesserly pushed a commit to dart-archive/polymer-dart that referenced this pull request Dec 20, 2014
we're still missing a few commits (such as Polymer/polymer#328) but this gets us pretty close to fixing https://code.google.com/p/dart/issues/detail?id=14377

R=sigmund@google.com

Review URL: https://codereview.chromium.org//30183005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart/pkg/polymer@29192 260f80e4-7a28-3924-810f-c04153c831b5
@kevmoo kevmoo deleted the event-bindings branch March 18, 2015 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants