Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use document-wide passive touch listener to update ghostclick blocker #4131

Merged
merged 4 commits into from
Nov 4, 2016
Merged

Use document-wide passive touch listener to update ghostclick blocker #4131

merged 4 commits into from
Nov 4, 2016

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented Nov 4, 2016

Fixes #4128

sorvell
sorvell suggested changes Nov 4, 2016
View reviewed changes
Copy link
Contributor

@sorvell sorvell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test that shows the scenario described in #4128 is resolved?

Actually this test does address #4128 by testing a tap an an element without a gesture immediately after a tap on an element with a gesture.

@sorvell sorvell assigned dfreedm and unassigned sorvell Nov 4, 2016
@dfreedm dfreedm merged commit 37eef0e into master Nov 4, 2016
@dfreedm dfreedm deleted the fix-ghostclick-nogesture branch November 4, 2016 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorvell sorvell sorvell approved these changes

Assignees

@dfreedm dfreedm

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfreedm @sorvell @googlebot