Only style elements with templates #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom-repeat and/or dom-if booting before custom-style is registered can break the complicated loading strategy of ShadyCSS. By only calling ShadyCSS for elements with templates, we both fix this issue and improve performance for template-less element booting Fixes #4521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dom-repeat and/or dom-if booting before custom-style is registered
can break the complicated loading strategy of ShadyCSS.
By only calling ShadyCSS for elements with templates, we both fix this
issue and improve performance for template-less element booting
Fixes #4521